Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better wasmvm 1.1 integration test #988

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Better wasmvm 1.1 integration test #988

merged 2 commits into from
Sep 9, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 7, 2022

Relates to #903 and #980

Add an integration test to call the new supply query via reflect contract
Includes:

  • reflect contract version upgrade to v1.1.0
  • Add cosmwasm_1_1 capabiltiy

@alpe alpe added this to the v0.29.0 milestone Sep 7, 2022
Copy link

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the TestReflectTotalSupplyQuery test starts failing when you comment out the cosmwasm_1_1 capability, then everything's great!

x/wasm/keeper/reflect_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #988 (b462f86) into main (b8c1d76) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   59.25%   59.34%   +0.09%     
==========================================
  Files          51       51              
  Lines        6246     6246              
==========================================
+ Hits         3701     3707       +6     
+ Misses       2279     2272       -7     
- Partials      266      267       +1     
Impacted Files Coverage Δ
app/app.go 88.91% <100.00%> (ø)
x/wasm/keeper/keeper.go 88.24% <0.00%> (-0.34%) ⬇️
x/wasm/keeper/query_plugins.go 81.10% <0.00%> (+2.60%) ⬆️

app/app.go Show resolved Hide resolved
@alpe alpe requested a review from pinosu September 8, 2022 13:14
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 0e41c8c into main Sep 9, 2022
@alpe alpe deleted the 903_test branch September 9, 2022 06:36
@faddat faddat mentioned this pull request Oct 2, 2022
Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023
* Add cosmwasm_1_1 cability, bump reflect contract, supply query integration test

* Review feedback
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
* Add cosmwasm_1_1 cability, bump reflect contract, supply query integration test

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants